Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

Why is the class called TransactionEvent instead of Transaction? Is there such a thing as a transaction that cannot be said to have happened? Also, given 'event' has a special meaning in finance, if you are going to call this out, should it not be called TransactionOccurrence?

Recommended Changes

Incorrect subclass relationships.  

pas:TransactionEvent is something that does in fact happen, e.g. withdrawing $100 from an ATM. There for it is NOT an OccurrenceKind, which is defined as a " type of event, which has a description". It does in fact have a Date, where OccurrenceKind specifically lacks a Date.

ReFactoring Suggestions

Classes with names that are too general

...